Skip to content

feat(mobile): native tabs, board, New task and chat (native overhaul 4/4) - #7839

Merged
Prasad-D-Ware merged 6 commits into
mobile-native-overhaul/03from
mobile-native-overhaul/04
Nov 6, 2026
Merged

Prasad-D-Ware merged 6 commits into
mobile-native-overhaul/03from
mobile-native-overhaul/04

Conversation

@MohamedKamran

@MohamedKamran MohamedKamran commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Code changes: +9672 -12221
Tests: +7191 -3778
Others: +6 -29

Important

Stacked PR 4 of 4: the mobile native overhaul, split from #7419. Merge in order:

Order PR Contents
1 #7836 Native toolchain: dependencies, patches, config plugins, assets
2 #7837 New building blocks (nothing imports them yet)
3 #7838 Settings, Machines, terminal, Files and preview
4 #7839 ← this PR Native tabs, board, New task, chat, old-code removal

Base: mobile-native-overhaul/03 (#7838). The diff shows only this PR's changes.

Do not merge until #7838 has merged. Once it has, this PR retargets to main (or run gh pr edit 7839 --base main); then wait for CI and merge.

How to merge: use Squash and merge. Only the tip of this PR builds: the commits before the deletion commit leave the old screens referring to code they replace.

After this merges, main matches #7419 merged with current main exactly, and #7419 can be closed.

What

The navigation switch and the remaining screens. Six commits, for reviewing one at a time:

  1. Native tabs and shared chrome (+2.9k / −2.1k).
    • Native tabs replace the drawer, each tab gets a native large-title header, and header actions become native Stack.Toolbar items.
    • Pushed pages take the native back button under the glass bar.
    • Tokens, theme and the shared primitives are restyled, and the store-update prompt is a system alert.
  2. Workers, Projects and Pull Requests (+6.1k / −1.7k).
    • Workers: search, filter and spawn from the header, filter by machine and project with chips, archive by full swipe, native row menus.
    • Projects: cards ending in the orchestrator's round button.
    • Pull Requests and Notifications: open as sheets.
  3. New task (+3.1k / −1.2k). New task is a chat-style page, sharing one model control with chat, with effort as a slider and native pickers with search.
  4. Chat (+5.2k / −2.2k).
    • The composer is rebuilt, the session gets iOS 26's glass header and a native actions menu, and jump-to-latest floats over the timeline.
    • Android gets Material 3 model and approval menus.
    • Send to terminal sits beside the send and mic button.
  5. Remove code the switch left unused (−9.2k). The drawer and sidebar shell, ScreenHeader, unused primitives, and tests that only pinned styling.
  6. README.

It also replaces the in-between code from #7838 with the final versions.

Why

This is the part of #7419 that can't be split further safely: the navigation shell and the shared restyle change every remaining screen at once.

Before / After

Before After
Drawer navigation with drawn headers Native tabs with native large-title headers and toolbar items
Workers / Projects / PRs: drawn chrome Native search, filter chips, swipe-to-archive, M3 FAB (Android)
New task: a sheet A chat-style page sharing the chat's model control and effort slider
Chat composer and header: drawn Rebuilt composer, glass header, native actions menu

Screenshots of each tab and of chat on iOS and Android will be added from a simulator run.

How

Testing

  • At the tip: npm run typecheck passes, and npm test passes 347 files and 3,409 tests.
  • Earlier commits don't build on their own; see the merge note above.

Checklist

  • Branched from main (or continuing an existing PR branch)
  • One focused change; links the related issue when applicable
  • Follows AGENTS.md conventions and PR hygiene
  • Before / After filled in; UI changes include screenshots or a recording
  • Tests added/updated for user-visible behavior where it makes sense
  • Relevant CI checks pass for the area touched (go, frontend, etc.)

🤖 Generated with Claude Code

@MohamedKamran
MohamedKamran marked this pull request as ready for review November 5, 2026 15:06
MohamedKamran added a commit that referenced this pull request Nov 5, 2026
This branch (#7419) was too large to review: 354 commits and 858 files. Its
history couldn't be split by cherry-picking. Most commits fix earlier ones,
and a few commits touch hundreds of files across every area.

So the split was rebuilt from this branch's final code, merged with current
main, as a stack of four PRs. Each one typechecks and passes the full mobile
suite on top of the one below it:

1. #7836 mobile-native-overhaul/01: native toolchain, config plugins and
   assets (dependencies, patches, plugins, icons, fonts).
2. #7837 mobile-native-overhaul/02: 180 new building-block files that nothing
   on main imports yet.
3. #7838 mobile-native-overhaul/03: Settings, Machines, pairing, onboarding,
   terminal, Files and preview, rebuilt natively.
4. #7839 mobile-native-overhaul/04: native tabs, the shared restyle, Workers,
   Projects and Pull Requests, New task, chat, and removal of the old code.

Merge them in order, using merge commits for 1-3 and a squash for 4. After
each merge, retarget the next PR to main. The tip of #7839 is identical to
this branch merged with main, so main ends up with exactly this work.

#7838 carries a little bridging code that never existed here. It adds new
tokens, theme fields and ui props, keeps MachineGlyph and
sharedMachineSymbols, registers its new routes in the root layout, and
updates a few tests for the in-between state. It lets those screens run
beside the old board and chat until #7839 replaces it with this branch's
versions.

This commit changes no files. This branch and #7419 stay as the reference;
close #7419 once #7839 merges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

🏆 Review leaderboard

Oct 29, 2026–Nov 5, 2026 · UTC

Rank Reviewer PRs reviewed Review rounds PR comments
🥇 @ronishrohan @ronishrohan 52 94 16
🥈 @Vaibhaav-Tiwari @Vaibhaav-Tiwari 39 60 9
🥉 @Rishet11 @Rishet11 30 52 62
4 @nikhilachale @nikhilachale 12 70 3
5 @somewherelostt @somewherelostt 12 50 1
6 @Prasad-D-Ware @Prasad-D-Ware 10 12 0
7 @illegalcall @illegalcall 9 19 3
8 @Meraj-08 @Meraj-08 8 20 3
9 @harshitsinghbhandari @harshitsinghbhandari 5 10 0
10 @neversettle17-101 @neversettle17-101 5 7 2

Ranked by distinct external PRs reviewed, then review rounds, then PR comments. Self-activity and bot activity are excluded.

Show 8 more reviewers
Rank Reviewer PRs reviewed Review rounds PR comments
11 @Pritom14 @Pritom14 5 6 4
12 @ApexYash11 @ApexYash11 4 13 2
13 @Annieeeee11 @Annieeeee11 3 5 2
14 @mohakchakraborty2004 @mohakchakraborty2004 3 4 0
15 @codebanditssss @codebanditssss 3 3 1
16 @Vansh-Singhal @Vansh-Singhal 1 3 1
17 @wesleymatosdev @wesleymatosdev 1 2 1
18 @AgentWrapper @AgentWrapper 1 1 0

@MohamedKamran
MohamedKamran added this pull request to stack #7842 November 5, 2026 15:21
@MohamedKamran
MohamedKamran force-pushed the mobile-native-overhaul/04 branch from 3f0ab1b to 2992ed8 Compare November 5, 2026 15:26
@OrcInc OrcInc added comp/mobile Expo mobile product surface. enhancement New feature or request labels Nov 5, 2026

@Prasad-D-Ware Prasad-D-Ware left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the 15 commits added since round 4 (650e9c9 through b7b4028), and they're sound:

  • A send that hits a pending prompt now goes to the terminal once, without flipping the composer's route toggle.
  • The "N updated" pill now scrolls to the top once per tap. Before, a tap that changed nothing could make the list jump on a later re-sort.
  • Both keyboard fixes are narrow.
  • With Archive removed from the swipe rail, screen readers still reach it through the row's actions.

No docs still point at the 71 deleted files. CI is green, and the stack tip is byte-for-byte #7419 merged into current main.

Ronish's #7821: not a blocker for this stack. It makes small edits to the same mobile spawn files (app/spawn.tsx, lib/spawnModel.ts, lib/api.ts), so he'll redo those ~40 lines on top of this when he rebases #7821.

Other overlap: #7797 (RequestCard) and #7799 (app/spawn.tsx) touch the same files. #7794 touches a different line of accountHosts.ts and should merge cleanly.

Before merge:

  • Before/After screenshots. None of the four PRs has them yet, and the repo requires them.
  • A device run of the round-4 items: status bar colour, keyboard, light-mode board frost, Android menu gap.
  • Merging: main only allows linear history, so each PR has to be squash-merged; a merge commit is rejected. After each squash-merge, move the next PR onto main:
    1. Note the commit the next branch is built on: git merge-base origin/mobile-native-overhaul/0N origin/mobile-native-overhaul/0N+1.
    2. gh pr edit <next PR> --base main, then git rebase --onto origin/main <that commit> mobile-native-overhaul/0N+1 and git push --force-with-lease. Without the rebase the PR still carries the previous PR's original commits, which main now has as one squashed commit.
    3. The push re-runs CI against main (retargeting alone doesn't). Merge once Mobile, Public boundary and gitleaks are green, then delete the old base branch by hand, since the repo doesn't auto-delete branches.

@OrcInc OrcInc added this to the Desktop & UI milestone Nov 5, 2026
@MohamedKamran
MohamedKamran force-pushed the mobile-native-overhaul/04 branch from 2992ed8 to 9e16e8b Compare November 6, 2026 10:03
MohamedKamran and others added 6 commits November 6, 2026 15:37
Replaces the drawer with native tabs, gives each tab a native large-title
header, and declares header actions as native Stack.Toolbar items. Pushed pages
take the native back button under the glass bar. Restyles tokens, theme and
the shared ui primitives after T3 Code, and shows the store-update prompt as a
system alert.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…hrome

Workers: search, filter and spawn from the native header, filter by machine
and project with chips, archive by full swipe, native row menus. Projects:
cards ending in the orchestrator's round button, New task at the bottom right
on iOS and as an M3 FAB on Android. Pull Requests open as a header sheet with
a native segmented filter and project menu; Notifications open as a sheet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…controls

New task is a chat-style page. Chat and New task share one model control,
with effort as a slider, and the model, agent, skill and reviewer pickers are
native lists with search.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rebuilds the composer, gives the session iOS 26's glass header and a native
pull-down actions menu, floats a jump-to-latest control, uses Material 3 model
and approval menus on Android, and brings Send to terminal back beside the send
and mic button. Rendered pages expand into a modal route with a native bar.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…h left unused

Deletes the drawer and sidebar shell, ScreenHeader and HeaderIconButton,
the unused primitives and the tests that only pinned styling.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The board is native tabs now, not a drawer.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MohamedKamran
MohamedKamran force-pushed the mobile-native-overhaul/04 branch from 9e16e8b to 16cf0aa Compare November 6, 2026 10:08
@MohamedKamran

Copy link
Copy Markdown
Collaborator Author

Screenshots at the stack tip

Debug builds of 16cf0aa9c9 (the tip of this stack, including #7836's switch to ios.enableSceneSupport), connected to a real daemon.

  • iOS: iPhone 18 Pro simulator on iOS 27.2. The app launches cleanly with Expo's scene support.
  • Android: Android 17 (API 37) emulator.

Both run in dark mode with the Orchestrate theme, in flow order: board → project → New task → chat → artifacts → files → preview → PRs → notifications → settings → pairing.

iOS (19 screens)

iOS 27.2 screens: Workers, Projects, project, New task, chat, artifacts, files, diff, preview, pull requests, PR review, notifications, settings, theme, machine, pair, connect manually, onboarding

Android (22 screens)

Android 17 screens: Workers, filter menu, Projects, project, New task, chat, chat actions, model menu, artifacts, files, diff, preview, pull requests, PR review, notifications, settings, theme, machine, pair, connect manually, onboarding

Not shown: a terminal-mode session, since none was running. On iOS, the chat ⋯ sheet and model menu are shown on Android only.

@Prasad-D-Ware Prasad-D-Ware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed after the rebase: every commit's diff is unchanged, CI is green, and the tip still merges cleanly into current main (none of main's newer commits touch mobile). The iOS 27.2 and Android 17 screenshots cover the flow. We'll do the light-mode and final device check on main after merge. Approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/mobile Expo mobile product surface. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants